Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#725 - anyPattern error improvements #738

Merged
merged 5 commits into from
Mar 18, 2020
Merged

#725 - anyPattern error improvements #738

merged 5 commits into from
Mar 18, 2020

Conversation

shravanshetty1
Copy link
Contributor

closes #725

@shravanshetty1
Copy link
Contributor Author

Revised error:
Screenshot from 2020-03-06 17-11-06

The previous error has been logged

JimBugwadia
JimBugwadia requested changes Mar 13, 2020
View reviewed changes
Copy link
Member

@JimBugwadia JimBugwadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better! Would also suggest adding the user defined message from the policy rule.

@shravanshetty1
Copy link
Contributor Author

@JimBugwadia @realshuting
Screenshot from 2020-03-16 14-07-17
If rule message exists, it will be returned as the error - however if it does not exist the previous message will be sent.

Requested changes have been made

@JimBugwadia JimBugwadia self-requested a review March 18, 2020 19:35
@JimBugwadia JimBugwadia merged commit 77b1294 into kyverno:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBugwadia JimBugwadia JimBugwadia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Any pattern error message needs improvement
2 participants
@shravanshetty1 @JimBugwadia