golangci-lint changes #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
golangcibot
reviewed
Mar 23, 2020
cmd/initContainer/main.go
Outdated
| flag.Set("v", "2") | ||
| err := flag.Set("logtostderr", "true") | ||
| if err != nil { | ||
| glog.Errorf("failed to set flag", err) |
There was a problem hiding this comment.
printf: Errorf call has arguments but no formatting directives (from govet)
cmd/initContainer/main.go
Outdated
| } | ||
| err = flag.Set("stderrthreshold", "WARNING") | ||
| if err != nil { | ||
| glog.Errorf("failed to set flag", err) |
There was a problem hiding this comment.
printf: Errorf call has arguments but no formatting directives (from govet)
cmd/initContainer/main.go
Outdated
| } | ||
| err = flag.Set("v", "2") | ||
| if err != nil { | ||
| glog.Errorf("failed to set flag", err) |
There was a problem hiding this comment.
printf: Errorf call has arguments but no formatting directives (from govet)
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
shivdudhani
approved these changes
Mar 24, 2020
realshuting
approved these changes
Mar 25, 2020
shravanshetty1
approved these changes
Mar 25, 2020
|
@evalsocket |
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
added 2 commits
March 27, 2020 14:39
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
realshuting
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Support Changes for #751
Signed-off-by: Yuvraj yuvraj.yad001@gmail.com