#754 - Validate policy schema #764
Conversation
shravanshetty1
changed the title
| // normal marshal would cause empty sub structs in | ||
| // policy to be non nil. | ||
| // TODO This needs to be removed. A simpler way to encode and decode Policy is needed. | ||
| func MarshalPolicy(policy v1.ClusterPolicy) []byte { |
There was a problem hiding this comment.
Agreed, was facing the issue before.
Do you think to change the type in the Policy struct would help?
i.e. add a pointer to Mutation
type Rule struct {
Mutation *Mutation `json:"mutate,omitempty"`
}
There was a problem hiding this comment.
Yes, it would - but this would be a big change and should be tracked in a seperate issue
There was a problem hiding this comment.
With the suggestion, we are moving from value to pointer semantics.
This was added for optimization, as its easier to manage values than use pointer.
If we plan to remove this optimization, then this needs to updated all places.
| // normal marshal would cause empty sub structs in | ||
| // policy to be non nil. | ||
| // TODO This needs to be removed. A simpler way to encode and decode Policy is needed. | ||
| func MarshalPolicy(policy v1.ClusterPolicy) []byte { |
There was a problem hiding this comment.
With the suggestion, we are moving from value to pointer semantics.
This was added for optimization, as its easier to manage values than use pointer.
If we plan to remove this optimization, then this needs to updated all places.
|
@shravanshetty1 Can you please resolve conflicts? |
fixes #754