-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Kyverno CLI #7995
Refactor Kyverno CLI #7995
Conversation
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
@anushkamittal2001 can you resolve conflicts ? |
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
@anushkamittal2001 you have linter errors |
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #7995 +/- ##
==========================================
+ Coverage 33.16% 33.20% +0.04%
==========================================
Files 245 245
Lines 23039 23086 +47
==========================================
+ Hits 7640 7666 +26
- Misses 14600 14614 +14
- Partials 799 806 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤷
Explanation
Kyverno CLI is one of Kyverno’s oldest components that hasn't gotten much attention recently. This has led to gaps and inconsistency in its behavior providing for a bad user experience. Going forward, correcting the CLI with a new design and proper schema is of importance.
Related issue
Closes #7994
Milestone of this PR
What type of PR is this
Proposed Changes
Correct the way we invoke Kyverno engine in CLI
Split different aspects of the CLI - ex - showing results should be separate render package, just like load resource/policy
Resolve issues related to CLI while making code changes per command
Proof Manifests
Checklist
Further Comments
This is a draft PR, will keep updating this as and when changes are made.