-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly invoking Kyverno engine in Kyverno CLI #8101
Closed
anushkamittal2001
wants to merge
12
commits into
kyverno:main
from
anushkamittal2001:invoke-engine-order
Closed
Correctly invoking Kyverno engine in Kyverno CLI #8101
anushkamittal2001
wants to merge
12
commits into
kyverno:main
from
anushkamittal2001:invoke-engine-order
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #8101 +/- ##
==========================================
+ Coverage 33.05% 33.33% +0.27%
==========================================
Files 252 252
Lines 23719 24050 +331
==========================================
+ Hits 7841 8016 +175
- Misses 15058 15192 +134
- Partials 820 842 +22
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Signed-off-by: anushkamittal2001 <anushka@nirmata.com>
Many conflicts to now resolve. |
Closing, done in #8327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We want to correct the way Kyverno engine is invoked in Kyverno CLI
Related issue
Fixes #7994
Milestone of this PR
What type of PR is this
Proposed Changes
ApplyPolicyConfig
struct now takes a slice of policies instead of a single policy. We are then changing the way Kyverno engine is invoked in the CLI. Now on a single resource we apply all mutate policies, then verifyImage then validate then generate policies.Proof Manifests
This PR contains mostly refactoring, all the unit test cases in
apply_command_test.go
andcommon_test.go
passChecklist
Further Comments
Reference doc for this PR