Feature - Add checks for k8s version when Kyverno starts #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shravanshetty1 Can you also help to review this PR :) |
shravanshetty1
suggested changes
May 13, 2020
There was a problem hiding this comment.
All existing middlewares and future middlewares should be a part of the middleware package.
Also existing logic regarding webhookTimeout needs to be removed - and needs to be tested with the older version of kubernetes as stated in issue #771
|
Also mutate and validate is not allowed before kubernetes 1.14 - hence we should refactor the code to handle this and any future cases where based on version we dont want to support some features. |
yindia
changed the title
added 2 commits
May 15, 2020 14:36
…actore kubernetes version check
realshuting
requested changes
May 17, 2020
added 2 commits
May 17, 2020 14:10
* 'fix-771' of github.com:evalsocket/kyverno: Removed log
realshuting
reviewed
May 18, 2020
realshuting
requested changes
May 18, 2020
added 2 commits
May 18, 2020 12:49
realshuting
requested changes
May 18, 2020
realshuting
reviewed
May 18, 2020
realshuting
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Prior to Kubernetes 1.14, there is no option to tune
timeoutfor webhookconfigurations. We need to add strict checks on the supported version of clusters:generatefeature. Mutate / Validate policy should be ignored in these versions of clusters.Solution
We are adding additional check for Kubernetes version and added timeout middleware
Other changes