Feature - Change annotation for auto-generate pod controllers policy #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 15, 2020 04:52
* 'master' of github.com:nirmata/kyverno: (102 commits) fix 843 (#844) chart readme fixes Fix Helm chart README.md for Helm 3 Add Helm chart for Kyverno - #835 Documentation update 664 tested prototype 823 tested prototype Fixes #817 - slack channel URL 797 typo fix Fixes #797 - update example for mutate patch policy remove cpu limit in BP require_pod_requests_limits.yaml (#807) 808 test fixes 808_prototype 753 reverting autogen rule changes 786 fixed tests 786 tested prototype 775 circle ci fixes 753 fixing tests 775 working prototype 753_avoiding_duplicate_vals ...
yindia
changed the title
yindia
changed the title
realshuting
requested changes
May 16, 2020
pkg/webhooks/policymutation.go
Outdated
| controllers = "all" | ||
| if controllers == "all" { | ||
| controllers = "DaemonSet,Deployment,Job,StatefulSet" | ||
| } |
There was a problem hiding this comment.
What if controllers != "all"? It will pass in "" to generateRulePatches() in line 165.
pkg/webhooks/policymutation.go
Outdated
| return kyvernoRule{} | ||
| } | ||
| controllers = engine.PodControllers | ||
| if match.ResourceDescription.Name != "" || match.ResourceDescription.Selector != nil || |
There was a problem hiding this comment.
Please read the design doc to understand the logic: https://github.com/nirmata/kyverno/wiki/Auto-generating-rule-for-pod-controllers
realshuting
requested changes
May 17, 2020
realshuting
reviewed
May 17, 2020
realshuting
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This relates to #637 .
If a rule is defined for the pod, Kyverno will automatically generate the rule for pod controllers
DaemonSet, Deployment,Job and StatefulSetby inserting an annotationpod-policies.kyverno.io/autogen-controllers=allto the policy.While
DaemonSet, Deployment,Job and StatefulSetdoes not cover all the pod controllers, i.e. Replicaset, Replicationcontroller, cronJob.It would be clear if we change the default annotation to
pod-policies.kyverno.io/autogen-controllers=DaemonSet,Deployment,Job,StatefulSet.Solution
Other changes