Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove openapi package #8538

Merged
merged 13 commits into from Sep 27, 2023
Merged

refactor: remove openapi package #8538

merged 13 commits into from Sep 27, 2023

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented Sep 26, 2023 •
edited

Explanation

This PR removes openapi package.

Related issue

Fixes #8540

@eddycharly
refactor: openapi package
ebe28b1 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
Merge branch 'main' into refactor-openapi-2
baa33af
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited

Codecov Report

Merging #8538 (fc7eccf) into main (eedc993) will decrease coverage by 2.25%.
The diff coverage is 23.91%.

@@            Coverage Diff             @@
##             main    #8538      +/-   ##
==========================================
- Coverage   35.63%   33.39%   -2.25%     
==========================================
  Files         313      310       -3     
  Lines       25163    24708     -455     
==========================================
- Hits         8968     8251     -717     
- Misses      15305    15674     +369     
+ Partials      890      783     -107
Files Coverage Δ
cmd/cli/kubectl-kyverno/commands/apply/command.go 53.98% <100.00%> (+0.21%) ⬆️
pkg/webhooks/resource/fake.go 100.00% <100.00%> (ø)
pkg/webhooks/resource/handlers.go 56.25% <100.00%> (+0.49%) ⬆️
...d/cli/kubectl-kyverno/commands/oci/push/options.go 0.00% <0.00%> (ø)
cmd/cli/kubectl-kyverno/commands/test/command.go 12.75% <0.00%> (+0.33%) ⬆️
cmd/cli/kubectl-kyverno/commands/test/test.go 0.00% <0.00%> (ø)
pkg/webhooks/policy/handlers.go 0.00% <0.00%> (ø)
pkg/validation/policy/validate.go 11.16% <0.00%> (-42.41%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eddycharly
kubectl validate
1f92433 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly mentioned this pull request Sep 27, 2023
Closed
2 tasks
@eddycharly
rm
3875ac5 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
Merge branch 'main' into refactor-openapi-2
12aef62
@eddycharly eddycharly changed the title refactor: openapi package refactor: remove openapi package Sep 27, 2023
@eddycharly
Merge branch 'main' into refactor-openapi-2
5b40c5d
@eddycharly
fix
dd6713d 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
Merge branch 'main' into refactor-openapi-2
e324761
@eddycharly
fix
01ff3cb 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
go mod
61c6689 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly marked this pull request as ready for review September 27, 2023 11:50
MariamFahmy98
MariamFahmy98 reviewed Sep 27, 2023
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
@eddycharly
fix vscode
828b84e 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly added this to the Kyverno Release 1.11.0 milestone Sep 27, 2023
@eddycharly
Copy link
Member Author

/cherry-pick release-1.11

@eddycharly eddycharly enabled auto-merge (squash) September 27, 2023 13:32
@eddycharly eddycharly added the Documentation Update Documentation label Sep 27, 2023
@eddycharly eddycharly enabled auto-merge (squash) September 27, 2023 13:41
@eddycharly eddycharly merged commit 482c243 into kyverno:main Sep 27, 2023
215 of 217 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 27, 2023
@eddycharly
refactor: remove openapi package (#8538)
181fd2f 
* refactor: openapi package

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* kubectl validate

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* rm

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* go mod

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix vscode

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

---------

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Sep 27, 2023
Merged
@eddycharly eddycharly deleted the refactor-openapi-2 branch September 27, 2023 16:22
@eddycharly eddycharly added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Sep 27, 2023
eddycharly added a commit that referenced this pull request Sep 27, 2023
@gcp-cherry-pick-bot @eddycharly
refactor: remove openapi package (#8538) (#8547)
7d3bb30 
* refactor: openapi package



* kubectl validate



* rm



* fix



* fix



* go mod



* fix vscode



---------

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@realshuting
Copy link
Member

Do we need to update doc for this change?

swastik959 pushed a commit to swastik959/kyverno that referenced this pull request Nov 1, 2023
@eddycharly @swastik959
refactor: remove openapi package (kyverno#8538)
5e9aee1 
* refactor: openapi package

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* kubectl validate

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* rm

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* go mod

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix vscode

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

---------

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@chipzoller
Copy link
Member

Do we need to update doc for this change?

I'm not sure. What does this change mean for users who are using spec.schemaValidation: false? Does that field just do nothing now? It's not clear what user impact this change has. Side note: that's the whole reason for the PR template which, when deleted, means that information isn't captured.

@realshuting
Copy link
Member

I'm not sure. What does this change mean for users who are using spec.schemaValidation: false? Does that field just do nothing now?

It's just a no-op regardless of the value setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamFahmy98 MariamFahmy98 MariamFahmy98 left review comments

@realshuting realshuting realshuting approved these changes

@chipzoller chipzoller Awaiting requested review from chipzoller chipzoller is a code owner

@MarcelMue MarcelMue Awaiting requested review from MarcelMue MarcelMue is a code owner

Assignees
No one assigned
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required Documentation Update Documentation milestone 1.11.0
Projects
None yet
Milestone
Kyverno Release 1.11.0
Development

Successfully merging this pull request may close these issues.

[Cleanup] Remove fetching and caching of CRDs
4 participants
@eddycharly @realshuting @chipzoller @MariamFahmy98