fix(helm): skip deployment replicas validation in non-int value (cherry-pick #8539) #8543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
* fix(helm): skip deployment replicas validation in non-int value Signed-off-by: Erik Godding Boye <egboye@gmail.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> --------- Signed-off-by: Erik Godding Boye <egboye@gmail.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
gcp-cherry-pick-bot
bot
requested review from
treydock and
eddycharly
as code owners
Codecov Report
@@ Coverage Diff @@
## release-1.11 #8543 +/- ##
=============================================
Coverage 35.63% 35.63%
=============================================
Files 313 313
Lines 25160 25160
=============================================
Hits 8965 8965
Misses 15305 15305
Partials 890 890 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eddycharly
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(helm): skip deployment replicas validation in non-int value (#8539)
Signed-off-by: Erik Godding Boye egboye@gmail.com
Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com
Signed-off-by: Erik Godding Boye egboye@gmail.com
Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com
Co-authored-by: Charles-Edouard Brétéché charles.edouard@nirmata.com