Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #838 - skip adding crd if no schema is defined #862

Merged
merged 6 commits into from
May 19, 2020
Merged

fix #838 - skip adding crd if no schema is defined #862

merged 6 commits into from
May 19, 2020

Conversation

realshuting
Copy link
Member

@realshuting realshuting commented May 19, 2020 •
edited

JimBugwadia
JimBugwadia requested changes May 19, 2020
View reviewed changes
pkg/engine/mutation.go Outdated Show resolved Hide resolved
pkg/engine/utils.go Outdated Show resolved Hide resolved
pkg/engine/utils.go Outdated Show resolved Hide resolved
pkg/userinfo/roleRef.go
@@ -4,6 +4,7 @@ import (
"fmt"
"strings"

"github.com/nirmata/kyverno/pkg/engine"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above...

pkg/userinfo/roleRef.go Outdated Show resolved Hide resolved
@JimBugwadia JimBugwadia merged commit 930811d into kyverno:master May 19, 2020
@realshuting realshuting deleted the 744_deny_requests branch July 6, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBugwadia JimBugwadia JimBugwadia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@realshuting @JimBugwadia