Require CPU Limits #1019
Draft
Require CPU Limits #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipzoller
requested changes
May 19, 2024
There was a problem hiding this comment.
Once again, we have a policy for this here: https://kyverno.io/policies/best-practices/require-pod-requests-limits/require-pod-requests-limits/
In practice, Kubernetes will set requests equal to limits if no requests are specified, so this policy is functionally equivalent to the above.
This PR also lumps in the policy from your previous PR and should not.
|
I see I was mistaken. We don't have one which specifically requires CPU limits. Although the claim you make in your post isn't exactly correct, we can add such a policy to the library if you address issues. |
|
DCO is required here. |
|
Please sign off on your PR. |
Signed-off-by: nsagark <90008930+nsagark@users.noreply.github.com>
|
Sign off is not complete. |
|
Converting to draft until all basic requirements are met. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
This is Kyverno equivalent policy for below. Setting CPU limits on pods ensures fair distribution of resources, preventing any single pod from monopolizing CPU and impacting the performance of other pods. This practice enhances stability, predictability, and cost control, while also mitigating the noisy neighbor problem and facilitating efficient scaling in Kubernetes clusters. This policy ensures that cpu limits are set on every container.
https://github.com/bridgecrewio/checkov/blob/main/checkov/kubernetes/checks/resource/k8s/CPULimits.py
Checklist