Added policy to restrict clusterrole permissions for mutating and validating admission webhooks #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idating webhoooks.
chipzoller
reviewed
May 19, 2024
Comment on lines
+35
to
+43
| value: | ||
| - mutatingwebhookconfigurations | ||
| - validatingwebhookconfigurations | ||
| - key: "{{ element.verbs }}" | ||
| operator: AnyIn | ||
| value: | ||
| - create | ||
| - update | ||
| - patch |
There was a problem hiding this comment.
You also must account for wildcards here.
There was a problem hiding this comment.
resources still does not account for wildcards.
|
Updated the policy to account for wildcards. Please review. |
Signed-off-by: nsagark <90008930+nsagark@users.noreply.github.com>
|
DCO is required here. |
|
Please sign off on your PR. |
Signed-off-by: nsagark <90008930+nsagark@users.noreply.github.com>
|
Sign off is not complete. |
|
Converting to draft until all basic requirements are met. |
|
@nsagark, do you intend to complete this PR or shall we close it? |
|
@chipzoller I will work on these PR's next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…idating webhoooks.
Related Issue(s)
Description
This is Kyverno equivalent policy for below.
https://github.com/bridgecrewio/checkov/blob/main/checkov/kubernetes/checks/resource/k8s/RbacControlWebhooks.py
ClusterRoles that grant write permissions over admission webhook should be minimized to reduce powerful identities in the cluster. Validating admission webhooks can read every object admitted to the cluster, while mutating admission webhooks can read and mutate every object admitted to the cluster. As such, ClusterRoles that grant control over admission webhooks are granting near cluster admin privileges. Minimize such ClusterRoles to limit the number of powerful credentials that if compromised could take over the entire cluster
Checklist