Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add other policies in CEL expressions - Part 5 #968

Merged
merged 44 commits into from
Jun 3, 2024
Merged

feat: add other policies in CEL expressions - Part 5 #968

merged 44 commits into from
Jun 3, 2024
+3,212 −7

Conversation

Chandan-DK
Copy link
Contributor

@Chandan-DK Chandan-DK commented Apr 12, 2024 •
edited

Related Issue(s)

Partially addresses #891

Description

This PR includes the conversion of policies in the other folder to Kyverno CEL policies. Conversion of the policies is done in multiple PRs

Policies converted in this PR:

  • restrict-annotations
  • restrict-binding-clusteradmin
  • restrict-binding-system-groups
  • restrict-clusterrole-nodesproxy
  • restrict-controlplane-scheduling
  • restrict-deprecated-registry
  • restrict-escalation-verbs-roles
  • restrict-ingress-classes
  • restrict-ingress-defaultbackend
  • restrict-ingress-wildcard

Checklist

  • [] I have read the policy contribution guidelines.
  • [] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • [] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

@Chandan-DK
add CI test for directories starting with res in other-cel
e5567fa 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy restrict-annotations
c413c8c 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert restrict-annotations to cel
d0ca136 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
rename wrong pod names and annotation key
5fd5514 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy restrict-binding-clusteradmin
5f70d1a 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
add kyverno tests for restrict-binding-clusteradmin
2c86142 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert restrict-binding-clusteradmin to cel
7e00479 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy restrict-binding-system-groups
d23f921 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
add kyverno tests for restrict-binding-system-groups
9ff03c8 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
fix kind in chainsaw test resource
7e70859 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert restrict-binding-system-groups to cel
3b5d501 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy restrict-clusterrole-nodesproxy
e485af8 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
add kyverno tests for restrict-clusterrole-nodesproxy
b6112fc 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert restrict-clusterrole-nodesproxy
7c7152f 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy restrict-controlplane-scheduling
6f79c70 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
add test resources for restrict-controlplane-scheduling
695d76f 
Also renamed pods for clarity

Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert restrict-controlplane-scheduling
bcca786 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy restrict-deprecated-registry
b28f55e 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert restrict-deprecated-registry
2ba60ae 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
Merge branch 'main' into other-policies-cel-part-5
8749018
@Chandan-DK
copy restrict-escalation-verbs-roles
482a572 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
add edge case to chainsaw test for restrict-escalation-verbs-roles
004d750 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert restrict-escalation-verbs-roles to cel
ec90c98 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy restrict-ingress-classes
6debfaf 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert restrict-ingress-classes
f020e18 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy restrict-ingress-defaultbackend
7ef7aa4 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert restrict-ingress-defaultbackend
45a7fc6 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy restrict-ingress-wildcard
fe46873 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert restrict-ingress-wildcard
d4efdc6 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
fix invalid host name
110b550 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
rename wrong pod names and annotation key for restrict-annotations
8f43af5 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
add corresponding missing kyverno tests in other folder
a260c86 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
make corrections in other folder chainsaw tests
9ec0dfa 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
add edge case in chainsaw test for restrict-escalation-verbs-roles in…
79fa650 
… the other folder

Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK Chandan-DK marked this pull request as ready for review April 16, 2024 16:57
@Chandan-DK
rename files for clarity
1824c6b 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
add a new line at the end of files
bee3ebc 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@MariamFahmy98 MariamFahmy98 self-requested a review April 22, 2024 14:09
@MariamFahmy98 MariamFahmy98 self-assigned this Apr 23, 2024
@Chandan-DK
remove extra lines and comment
cb0967f 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@MariamFahmy98
Copy link
Contributor

@Chandan-DK - Could you please resolve the conflicts?

MariamFahmy98
MariamFahmy98 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MariamFahmy98 MariamFahmy98 merged commit 42de48b into kyverno:main Jun 3, 2024
179 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamFahmy98 MariamFahmy98 MariamFahmy98 approved these changes

Assignees

@MariamFahmy98 MariamFahmy98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Chandan-DK @MariamFahmy98