Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Kasten minimum retention policy #995

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mattbator
Copy link
Contributor

Related Issue(s)

N/A

Description

Updates k10-minimum-retention ClusterPolicy, adding precondition to ensure the policy only applies JSON patch to hourly Kasten policies. Filenames, policy/rule names, category, and keywords have been updated to reflect Kasten K10 rebranding to Veeam Kasten.

Checklist

  • I have read the policy contribution guidelines.
  • I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

Signed-off-by: Matt Bator <matt.bator@kasten.io>
Signed-off-by: Matt Bator <matt.bator@kasten.io>
Signed-off-by: Matt Bator <matt.bator@kasten.io>
Signed-off-by: Matt Bator <matt.bator@kasten.io>
Copy link
Member

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a minor typo? Reminder that any changes to policies require re-computing the digest for the purposes of Artifact Hub.

To use different
This policy can also be used go reduce retentions lengths to enforce cost optimization.
Kasten Policy resources can be validated to adhere to common compliance retention standards.
Based on regulation/compliance standard requirements, uncomment (1) of the desired GFS retention schedules to mutate existing and future Kasten Policies. Alternatively, this policy can be used go reduce retention lengths to enforce cost optimization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Based on regulation/compliance standard requirements, uncomment (1) of the desired GFS retention schedules to mutate existing and future Kasten Policies. Alternatively, this policy can be used go reduce retention lengths to enforce cost optimization.
Based on regulation/compliance standard requirements, uncomment (1) of the desired GFS retention schedules to mutate existing and future Kasten Policies. Alternatively, this policy can be used to reduce retention lengths to enforce cost optimization.

Comment on lines +15 to +16

NOTE: Only applies to Kasten Policies with an '@hourly' frequency. Refer to Kasten documentation for Policy API specification if modifications are necessary: https://docs.kasten.io/latest/api/policies.html#policy-api-type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here.

Suggested change
NOTE: Only applies to Kasten Policies with an '@hourly' frequency. Refer to Kasten documentation for Policy API specification if modifications are necessary: https://docs.kasten.io/latest/api/policies.html#policy-api-type
NOTE: Only applies to Kasten Policies with an '@hourly' frequency. Refer to Kasten documentation for Policy API specification if modifications are necessary: https://docs.kasten.io/latest/api/policies.html#policy-api-type

@chipzoller
Copy link
Member

Ping @mattbator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants