Replace k10-generate-gold-backup-policy ClusterPolicy #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Bator <matt.bator@kasten.io>
Signed-off-by: Matt Bator <matt.bator@kasten.io>
3 tasks
chipzoller
reviewed
May 28, 2024
kasten/kasten-generate-example-backup-policy/artifacthub-pkg.yml
Outdated
Show resolved
Hide resolved
This must not exist. The line is only for the policy itself and not any supporting resources. Signed-off-by: Chip Zoller <chipzoller@gmail.com>
chipzoller
reviewed
May 28, 2024
kasten/kasten-generate-example-backup-policy/artifacthub-pkg.yml
Outdated
Show resolved
Hide resolved
Don't need this per standards. Signed-off-by: Chip Zoller <chipzoller@gmail.com>
chipzoller
requested changes
May 31, 2024
Comment on lines
+21
to
+23
| Generates a Kasten policy for a namespace that includes any Deployment or StatefulSet with a "dataprotection=kasten-example" label, if the policy does not already exist. | ||
|
|
||
| Use with "kasten-data-protection-by-label" policy to require "dataprotection" labeling on workloads. |
There was a problem hiding this comment.
When using a folded line (block) scalar like this, you can't have an empty line or else it breaks rendering.
Suggested change
| Generates a Kasten policy for a namespace that includes any Deployment or StatefulSet with a "dataprotection=kasten-example" label, if the policy does not already exist. | |
| Use with "kasten-data-protection-by-label" policy to require "dataprotection" labeling on workloads. | |
| Generates a Kasten policy for a namespace that includes any Deployment or StatefulSet with a "dataprotection=kasten-example" label, if the policy does not already exist. Use with "kasten-data-protection-by-label" policy to require "dataprotection" labeling on workloads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
N/A
Description
Replaces
k10-generate-gold-backup-policywith a version that checks for duplicate policies and can more easily be adapted to environmental needs. Filenames, policy/rule names, category, and keywords have been updated to reflect Kasten K10 rebranding to Veeam Kasten.Checklist