fix: allow dropping metrics, labels and configuring histogram bucket boundaries to avoid high cardinality #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off. |
…boundaries to avoid high cardinality Signed-off-by: Rodrigo Fior Kuntzer <rodrigo@miro.com>
9 tasks
chipzoller
changed the title
realshuting
changed the title
realshuting
approved these changes
Oct 13, 2023
Congratulations! 🎉Great job merging your first Pull Request here! How awesome! If you are new to this project, feel free to join our Slack community.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
kyverno/kyverno#8401
kyverno/kyverno#8569
Proposed Changes
This changes evolves the metrics related configuration done via the
kyverno-metricsConfigMap, exposing two new fields as following:metricsExposure: this is a map of a struct allowing each metric to be disabled, filtered labels or changed the bucket boundaries.bucketBoundaries: this configures the default bucket boundaries for all histograms.It's worth mentioning this change does not change the default metrics configuration currently in use by Kyverno, meaning that all metrics, labels and bucket dimensions currently in use are preserved by default.
Checklist