Minor cmake tweaks for Pangolin and Eigen #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 changes I think should be included:
find_package
should haveQUIET
.a) Eigen3 is now a target, not set of variables. This means it's now first-class citizen in terms of cmake dependencies.
b) this requires to have workaround for some unfortunate mistake on Eigen's part that got deployed on some distributions (Ubuntu for example) - Eigen exported vars but not a library.
This workaround allows to write code as expected from official Eigen doc: https://eigen.tuxfamily.org/dox-devel/TopicCMakeGuide.html