+ Correct key disposing (memory leak)

+ Aggressive Inlining
kzorin52 · Jan 19, 2024 · fbd0027 · fbd0027
1 parent 9f5339a
commit fbd0027
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/Algos/Ed25519HdKey.cs b/Algos/Ed25519HdKey.cs
@@ -16,10 +16,8 @@ public HdKey GetMasterKeyFromSeed(ReadOnlySpan<byte> seed)
 
     public byte[] GetPublic(ReadOnlySpan<byte> privateKey)
     {
-        return Key.Import(SignatureAlgorithm.Ed25519,
-                privateKey,
-                KeyBlobFormat.RawPrivateKey).PublicKey
-            .Export(KeyBlobFormat.RawPublicKey);
+        using var key = Key.Import(SignatureAlgorithm.Ed25519, privateKey, KeyBlobFormat.RawPrivateKey);
+        return key.PublicKey.Export(KeyBlobFormat.RawPublicKey);
     }
     /* some my benchamrks:
        | Method       | Mean     | Error    | StdDev   |

diff --git a/Interfaces/IHdKeyAlgo.cs b/Interfaces/IHdKeyAlgo.cs
@@ -1,4 +1,5 @@
-using System.Security.Cryptography;
+using System.Runtime.CompilerServices;
+using System.Security.Cryptography;
 
 namespace NBip32Fast.Interfaces;
 
@@ -33,11 +34,13 @@ public HdKey DeriveFromMasterKey(ReadOnlySpan<KeyPathElement> path, HdKey master
 
     public byte[] GetPublic(ReadOnlySpan<byte> privateKey);
 
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     protected static byte[] Bip32Hash(ReadOnlySpan<byte> chainCode, KeyPathElement index, byte[] data)
     {
         return HMACSHA512.HashData(chainCode, [.. data, .. index.Serialized.Span]);
     }
 
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     protected static byte[] Bip32Hash(ReadOnlySpan<byte> chainCode, KeyPathElement index, byte prefix, ReadOnlySpan<byte> data)
     {
         return HMACSHA512.HashData(chainCode, [prefix, .. data, .. index.Serialized.Span]);

diff --git a/KeyPath.cs b/KeyPath.cs
@@ -1,4 +1,5 @@
-using System.Text;
+using System.Runtime.CompilerServices;
+using System.Text;
 
 namespace NBip32Fast;
 
@@ -149,6 +150,7 @@ public override int GetHashCode()
 
     #endregion
 
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static byte[] SerializeUInt32(in uint index)
     {
         return

diff --git a/NBip32Fast.csproj b/NBip32Fast.csproj
@@ -17,7 +17,7 @@ Supports SecP256k1 and Ed25519</Description>
 	<PropertyGroup>
 		<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
 		<PackageReadmeFile>README.md</PackageReadmeFile>
-		<Version>1.0.1</Version>
+		<Version>1.0.3</Version>
 	</PropertyGroup>
 
 	<ItemGroup>