Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent score names between ortho_projection and predict (pls method) #49

Closed
zecojls opened this issue Jan 11, 2024 · 1 comment
Closed
Assignees

Comments

@zecojls
Copy link

zecojls commented Jan 11, 2024

Hi Leo,

I think this is just a small fix...

When I compress a matrix of spectra using 'pls' method...

ortho_projection(Xr = pls.data, Xu = NULL, Yr = target, method = "pls", pc_selection = list(method = "manual", value = 3))

The scores matrix from this object are column-named pls_1, pls_2, and pls_3.

If I predict new spectra with this trained model, the scores column names are pls1, pls2, and pls2, requiring that I rename it within the pipeline for plotting or analyzing both datasets in conjunction.

This does not happen for method pca.

Thanks

@l-ramirez-lopez l-ramirez-lopez self-assigned this Feb 15, 2024
@l-ramirez-lopez
Copy link
Owner

Thanks Jose
this has been fixed and will go into the next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants