forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[iOS] Enable edit button when no active but inactive tabs
When a user is in the regular tab grid, the "Close All" option should be available if there is inactive tab to close even if there is no actives. This CL add dynamic update to the Edit button in the following scenario: * When the regular tab grid is empty but there is inactive tabs then "Edit" button is available and only have "Close All" options See video: https://drive.google.com/file/d/1yDpOQjaMNaqyLbCOTlFTT68ctFWZHpMl/view?usp=share_link * When there is no active nor inactive then "Edit" is not available See screenshot: https://drive.google.com/file/d/1U_6s-UQBYjYZgte_6GbN0rukRz29qAGC/view?usp=share_link * For incognito, the "Edit" button should behave as before See video: https://drive.google.com/file/d/1Z7EJnpHT4X9G8KcrtrYursPPcfj0MGDC/view?usp=share_link (cherry picked from commit 9bee1ec) Fixed: 1434217 Change-Id: I8e14eff68554f1252647f67f685339fc6e46b467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4481598 Reviewed-by: Louis Romero <lpromero@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Aliona Dangla <alionadangla@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1137170} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4498428 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Aliona Dangla <alionadangla@chromium.org> Cr-Commit-Position: refs/branch-heads/5735@{chromium#145} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
- Loading branch information
Showing
3 changed files
with
31 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters