Implement new main page #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torztomasz
force-pushed
the
implement-new-main-page
branch
from
bfa35a7
to
4fe0a63
Compare
torztomasz
force-pushed
the
implement-new-main-page
branch
from
4fe0a63
to
5446ca1
Compare
sz-piotr
approved these changes
Aug 17, 2023
| entryShortNamePlural: 'transactions', | ||
| entryLongNamePlural: 'forced transactions', | ||
| path: '/forced-transactions', | ||
| } | ||
|
|
||
| export const OFFER_TABLE_PROPS = { | ||
| title: 'Available forced trade offers', | ||
| title: 'Available offers', |
There was a problem hiding this comment.
Naming offers "forced trade offers" was something specifically requested by SW long ago. I'd only make this change if they approved it this way.
There was a problem hiding this comment.
They've accepted it 👍
| } | ||
|
|
||
| export function PerpetualL2TransactionsTable( | ||
| props: PerpetualL2TransactionsTableProps | ||
| ) { | ||
| const columns: Column[] = [ | ||
| { header: 'Age' }, | ||
| { header: `ID` }, |
There was a problem hiding this comment.
Maybe we could have an eslint rule for no unnecessary backticks? Not sure if a rule like this exists
| @@ -0,0 +1,26 @@ | |||
| import React from 'react' | |||
|
|
|||
| export function BreakpointIndicator() { | |||
There was a problem hiding this comment.
Not sure if this is the best place to put this component
| @@ -59,6 +57,7 @@ | |||
| "postcss": "^8.4.14", | |||
| "prettier": "^2.8.4", | |||
| "prettier-plugin-tailwindcss": "^0.2.2", | |||
| "tailwindcss": "^3.0.24" | |||
| "@tailwindcss/container-queries": "^0.1.1", | |||
There was a problem hiding this comment.
Really cool that this is so widely supported https://caniuse.com/css-container-queries. Didn't even know this existed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-1975