chore: Add test not to break legacy mode again

l7mp · May 10, 2024 · 374ecc5 · 374ecc5
1 parent 868704f
commit 374ecc5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/pkg/config/client/client_test.go b/pkg/config/client/client_test.go
@@ -8,7 +8,14 @@ import (
 
 func TestParseURI(t *testing.T) {
 	// file
-	u, err := getURI("/tmp/a")
+	u, err := getURI("file:///tmp/a")
+	assert.NoError(t, err, "file URI parse")
+	assert.Equal(t, "file", u.Scheme, "file URI scheme")
+	assert.Equal(t, "", u.Host, "file URI host")
+	assert.Equal(t, "/tmp/a", u.Path, "file URI path")
+
+	// default is http
+	u, err = getURI("/tmp/a")
 	assert.NoError(t, err, "file URI parse")
 	assert.Equal(t, "http", u.Scheme, "file URI scheme")
 	assert.Equal(t, "", u.Host, "file URI host")

diff --git a/pkg/config/client/util.go b/pkg/config/client/util.go
@@ -29,7 +29,7 @@ func decodeConfigList(r []byte) ([]*stnrv1.StunnerConfig, error) {
 
 // getURI tries to parse an address or an URL or a file name into an URL.
 func getURI(addr string) (*url.URL, error) {
-	// make sure we have a working HTTP scheme
+	// default URL scheme is "http"
 	if !strings.HasPrefix(addr, "http://") && !strings.HasPrefix(addr, "https://") &&
 		!strings.HasPrefix(addr, "ws://") && !strings.HasPrefix(addr, "wss://") &&
 		!strings.HasPrefix(addr, "file://") {