Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add helper scripts to download stunner tools #124

Merged
merged 6 commits into from
Feb 21, 2024

Conversation

levaitamas
Copy link
Member

This PR adds helper scripts to download future turncat and stunnerctl binaries from github release assets. The scripts work on Linux and MacOS systems. Windows users we are sorry, however PRs welcome.

Currently we have no stable release with binaries available. The below sed oneliners edit the scripts to download test binaries from my fork:

sed -i "s|REPO=https://github.com/l7mp/stunner|REPO=https://github.com/levaitamas/stunner|" cmd/downloadStunnerCtl.sh

sed -i "s!REPO=https://github.com/l7mp/stunner!REPO=https://github.com/levaitamas/stunner!" cmd/downloadTurncat.sh

Acknowledment: scripts are baseod on downloadIstioctl. Thanks Istio devs!

@levaitamas levaitamas added the type: enhancement Feature request label Feb 10, 2024
@coveralls
Copy link

coveralls commented Feb 10, 2024

Pull Request Test Coverage Report for Build 7870660185

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.429%

Totals Coverage Status
Change from base Build 7818148938: 0.0%
Covered Lines: 965
Relevant Lines: 1351

💛 - Coveralls

@rg0now
Copy link
Member

rg0now commented Feb 10, 2024

Thanks a lot, this is super-useful!

cmd/downloadStunnerCtl.sh Outdated Show resolved Hide resolved
cmd/downloadStunnerCtl.sh Outdated Show resolved Hide resolved
cmd/downloadTurncat.sh Outdated Show resolved Hide resolved
Copy link
Member

@rg0now rg0now left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this feature is shaping up nicely. Could you please add a short note to the installation section of the stunnerctl README and the turncat README on how to use this? The structure could be something like like "use the script to download the latest release" or "if you have the Go toolchain installed then you can also use go install".

Copy link
Member

@rg0now rg0now left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, perfect

@levaitamas levaitamas merged commit ce15c43 into main Feb 21, 2024
3 checks passed
@levaitamas levaitamas deleted the download-helper-scripts branch February 21, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants