Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some forms only have one HTML template #263

Merged
merged 1 commit into from Jul 16, 2021

Conversation

xylo04
Copy link
Contributor

@xylo04 xylo04 commented Jul 15, 2021

When a form .txt file only specifies one HTML template, it's supposed to be used for both compose and view.

Also fix a Javascript error. Now that "RADIOGRAM & RRI Forms" is coming through, we can't have ampersand in an HTML element ID.

Resolves #262

When a form .txt file only specifies one HTML template, it's supposed to be used for both compose and view.

Also fix a Javascript error. Now that "RADIOGRAM & RRI Forms" is coming through, we can't have ampersand in an HTML element ID.
Copy link
Member

@martinhpedersen martinhpedersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I would have split this into two commits, but that's just me nitpicking😅

@martinhpedersen martinhpedersen merged commit 3246c2e into la5nta:develop Jul 16, 2021
@xylo04 xylo04 deleted the bug/262 branch July 19, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants