Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "All Threads" view is not styled and garishly white. #218

Closed
Drarok opened this issue Mar 15, 2019 · 6 comments
Closed

The "All Threads" view is not styled and garishly white. #218

Drarok opened this issue Mar 15, 2019 · 6 comments

Comments

@Drarok
Copy link

Drarok commented Mar 15, 2019

I've collected some custom styles in order to combat this, which makes it look less bad overall, but still needs improving.

.p-threads_view {
  background: #222;
}

.p-threads_view__divider_line {
  border-color: #111;
}

.p-threads_view__divider_label {
  background: #111;
}

.p-threads_view_header__channel_name {
  color: #c7c7c7;
}

.p-threads_view_root {
  border-color: #444;
}

.p-threads_view_reply {
  border-color: #444;
}

.p_threads_view_load_newer_button,
.p_threads_view_load_older_button {
  background: rgba(255, 255, 255, 0.05);
  border-color: #444;
}

.p-threads_view__footer {
  border-color: #444;
}

.p-threads_view__default_background {
  background: rgba(255, 255, 255, 0.05);
}

Before:
Screenshot 2019-03-15 at 17 28 59

After:
Screenshot 2019-03-15 at 17 30 46

@Lemmmy
Copy link
Contributor

Lemmmy commented Mar 16, 2019

Seems that #threads-msgs has changed to .p-threads_view, the whole UI has been re-done:

https://github.com/laCour/slack-night-mode/blob/master/scss/modules/messaging/_threads.scss

jg-made added a commit to jg-made/jg-made-system that referenced this issue Mar 22, 2019
kaedys pushed a commit to kaedys/slack-night-mode that referenced this issue Mar 26, 2019
mykeels added a commit to mykeels/slack-theme-cli that referenced this issue Mar 28, 2019
@mxr
Copy link

mxr commented Mar 28, 2019

@Drarok thanks for the workaround. I'm using it in the meantime. I also added this locally:

.p-threads_view_reply--new_reply {
      background: rgba(255, 255, 255, 0.05);
}

Otherwise new replies in the all-threads view have too light of a background.

rossmckelvie added a commit to rossmckelvie/slack-night-mode that referenced this issue Mar 29, 2019
rossmckelvie added a commit to rossmckelvie/slack-night-mode that referenced this issue Mar 29, 2019
gibfahn pushed a commit to gibfahn/slack-night-mode that referenced this issue Apr 3, 2019
@shmerl
Copy link

shmerl commented Apr 12, 2019

Arc is also affected.

@vfede vfede mentioned this issue Apr 29, 2019
adeebahmed pushed a commit to adeebahmed/slack-night-mode that referenced this issue May 14, 2019
Added styles from laCour#218 and a few others to black.css
@shibatak1124
Copy link

Which local file should I edit to add a custom style?

mastermel added a commit that referenced this issue May 31, 2019
Refs #229, #226, #218

This adds style overrides for the new selectors Slack begain using for
its Threads screen, beginning with the .p-threads_view container.

Test Plan:
- Have one or more threads that you've participated in and view the
  "Threads" screen from the left navigation panel
- Verify that the colors match the theme and everything is legible
- Verify that the button links for loding more replies in a thread are
  colored to match the theme and are legible
@mastermel
Copy link
Collaborator

This has been improved in the latest release! Please let us know if you continue to see any issues after updating 😄

@Lemmmy
Copy link
Contributor

Lemmmy commented May 31, 2019

The loading screen for the threads view is still a bit crazy

.p-message_container_loading

Zoooook pushed a commit to Zoooook/slack-night-mode that referenced this issue Jul 3, 2020
Refs laCour#229, laCour#226, laCour#218

This adds style overrides for the new selectors Slack begain using for
its Threads screen, beginning with the .p-threads_view container.

Test Plan:
- Have one or more threads that you've participated in and view the
  "Threads" screen from the left navigation panel
- Verify that the colors match the theme and everything is legible
- Verify that the button links for loding more replies in a thread are
  colored to match the theme and are legible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants