This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
[WIP] Better exit file handling #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit file is removed once used. Structure is improved to remove code duplication. Some issues possibly remain, more testing needed.
|
Changed target to master |
|
@OndrejMarsalek as you see I'm doing some spring cleaning. Any chance this can be merged soon? |
|
@OndrejMarsalek is this ready to merge? |
tomspur
reviewed
Nov 24, 2017
| # TODO: This does not continue smoothly from the RESTART when EXIT | ||
| # is found, but EXIT_step seems fine. | ||
| softexit.check_exit_file() | ||
| softexit.check_exit_file("EXIT_{:d}".format(self.step)) |
There was a problem hiding this comment.
Should there also be a timeout check?
tomspur
reviewed
Nov 24, 2017
| break | ||
| # Check for exit files also here. This can have shorter latency | ||
| # than the regular check and also can stop at specific step. | ||
| # TODO: This does not continue smoothly from the RESTART when EXIT |
There was a problem hiding this comment.
Were these "not smoothly continuations" the possible remaining issues, that you wanted to test further?
|
Can this be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit file is removed once used. Code structure is improved to remove code duplication - only
Softexitperforms checking.As a bonus, we now also check for the file
EXIT_<step number>to be able to cut a given run short at a specific step. This should be documented.Some issues possibly remain, more testing needed - do not merge yet.