Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Collector for *"database/sql".DB #2

Merged
merged 2 commits into from
Dec 23, 2019
Merged

✨ Collector for *"database/sql".DB #2

merged 2 commits into from
Dec 23, 2019

Conversation

jamillosantos
Copy link
Contributor

✨ Enhancements

  • Implement a new Collector for collecting data from a *sql.DB instance (using .Stats());

@jamillosantos jamillosantos added the enhancement New feature or request label Dec 18, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #2 into master will increase coverage by 1.6%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #2     +/-   ##
=========================================
+ Coverage   45.94%   47.55%   +1.6%     
=========================================
  Files           5        6      +1     
  Lines         827      860     +33     
=========================================
+ Hits          380      409     +29     
- Misses        423      425      +2     
- Partials       24       26      +2
Impacted Files Coverage Δ
promsql/collector.go 100% <100%> (ø)
promfasthttp/instrument_server.go 35.16% <0%> (-0.85%) ⬇️
promhermes/instrument_server.go 35.24% <0%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ba87f...b5eb5e5. Read the comment docs.

Copy link
Contributor

@felipemfp felipemfp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉👍

Copy link
Contributor

@chicobentojr chicobentojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✌️

@jamillosantos jamillosantos merged commit af7fb93 into master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants