Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver collector #3

Merged
merged 9 commits into from
Jan 21, 2020
Merged

Add driver collector #3

merged 9 commits into from
Jan 21, 2020

Conversation

chicobentojr
Copy link
Contributor

✨ Enhancements

  • Add collector to capture sql client metrics to publish using prometheus

@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #3 into master will decrease coverage by 2.89%.
The diff coverage is 39%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #3     +/-   ##
=========================================
- Coverage   47.79%   44.89%   -2.9%     
=========================================
  Files           6        7      +1     
  Lines         860     1283    +423     
=========================================
+ Hits          411      576    +165     
- Misses        423      670    +247     
- Partials       26       37     +11
Impacted Files Coverage Δ
promsql/driver_collector.go 39% <39%> (ø)
promfasthttp/instrument_server.go 35.16% <0%> (-0.43%) ⬇️
promhermes/instrument_server.go 36.06% <0%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7fb93...87a220c. Read the comment docs.

Copy link
Contributor

@jamillosantos jamillosantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, consider adding a full example (:star2: with docker-compose) to show how to use it.

Also, would be nice to write some documentation.

promsql/driver_collector.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jamillosantos jamillosantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After creating this extension, I think now you are able to better understand (and I too) where we want to go with these metrics. That said...

What are we measuring with TransactionFailedCounter? And what do we want/need to measure while dealing with transactions?

promsql/driver_collector.go Outdated Show resolved Hide resolved
Copy link
Contributor

@felipemfp felipemfp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉👍

@jamillosantos jamillosantos merged commit 6d0a676 into master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants