-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add driver collector #3
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=========================================
- Coverage 47.79% 44.89% -2.9%
=========================================
Files 6 7 +1
Lines 860 1283 +423
=========================================
+ Hits 411 576 +165
- Misses 423 670 +247
- Partials 26 37 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, consider adding a full example (:star2: with docker-compose) to show how to use it.
Also, would be nice to write some documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After creating this extension, I think now you are able to better understand (and I too) where we want to go with these metrics. That said...
What are we measuring with TransactionFailedCounter
? And what do we want/need to measure while dealing with transactions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉👍
✨ Enhancements