Add the protein sequence to gene family when reading clustering #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When external clustering is provided, gene families sequences were missing in the pangenome file. This resulted in some output files being impossible to generated. We especially noticed that the FASTA file of RGP borders (created by
ppanggolin write_pangenome --borders) was containing only sequence IDs without actual sequences.This PR adds functionality to translate the representative gene of each gene family in the cluster step, enabling the writing of the protein sequence into the HDF5 pangenome file.
This change should resolve the issue of missing sequence outputs.