Hack20 test region #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion of new tests.
|
Looks good to me ! getBorderingGenes is there to extract persistent genes that are bordering the region, so typically the n genes before and the n genes after the region along the contig to which the region belongs. It is quite related to the Spot class, as we define a spot of insertion by the bordering genes of those regions - if regions have the same genomic context (i.e they have the same bordering gene families), then they are in the same area of the genomes even though they may not have a lot of genes in common. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for Region class updated.
I did not do fully getBorderingGenes because I have some difficulty to understand its purpose.