Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handled a bug with packing more than was read #106

Closed
wants to merge 1 commit into from

Conversation

MickMack1983
Copy link

When readBytes is less than len(*newA) pack fails with
" struct.error: pack expected 192 items for packing (got 256)"

This pull requests solves that

@davelopez01
Copy link
Collaborator

davelopez01 commented Mar 26, 2018

What code or stream settings are you using to get "struct.error: pack expected 192 items for packing (got 256)", what LabJack are you using, and what operating system are you using?

@davelopez01
Copy link
Collaborator

@MickMack1983, for me to look into this further and consider merging your commit, please provide the details I requested in my previous comment. I want to reproduce the issue you were seeing, and check on what is causing the smaller packet sizes than requested and if data is lost.

@davelopez01
Copy link
Collaborator

Not accepting the pull request and closing.

@mnaberez
Copy link
Contributor

I agree with the decision to not merge a pull request unless we understand it. However, I hope that @MickMack1983 can add the reproduce instructions here eventually so we can revisit it. If this bug occurred during normal usage, learning more about it might result in other changes as well. For example, it might lead to better validation of streaming settings, a change to ExoDriver, better docs, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants