-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of nginx ingress controller #216
Allow configuration of nginx ingress controller #216
Conversation
72bb0d1
to
1dd3ae9
Compare
I updated the PR to make all values in this file configurable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this should be marked as a Breaking Change; if you previously used the custom manifest deployment method to deploy those nginx configuration options, this will overwrite that custom manifest. In our case, our deployment was failing because use-forwarded-hearders: true was removed from the nginx config which caused our Rancher to get stuck in an HTTP 308 redirect loop. |
That's a good point @elbvdk. Thanks. Will add that to the release notes |
Thanks for the quick fix! |
Description
Allow configuration of default nginx certificate.
Type of change
How Has This Been Tested?
I executed the role on my cluster and set
rke2_ingress_nginx_default_certificate: "cert-manager/default-cert"
. With cert-manager I created a certificate in the secretcert-manager/default-cert
.