Feat:Cancelled session's log button is disabled #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gee05053
added
type:enhance
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
lizable
reviewed
Nov 24, 2023
| @@ -2928,6 +2928,7 @@ ${rowData.item[this.sessionNameField]}</pre | |||
| class="fg blue controls-running" | |||
| id="${rowData.index + '-assignment'}" | |||
| icon="assignment" | |||
| ?disabled="${rowData.item.status === 'CANCELLED'}" | |||
There was a problem hiding this comment.
This is a minor thing, but I think we shall use triple equal (===) instead of ==. Please refer here.
There was a problem hiding this comment.
And I just changed the operator to triple equal sign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #2022
CANCELLED session's log button is disabled
Checklist: (if applicable)