Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat:Cancelled session's log button is disabled #2045

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Feat:Cancelled session's log button is disabled #2045

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a760a7a
Apply disabled log button of cancelled session
gee05053 Nov 23, 2023
22831f2
misc: use triple equals when checking status
lizable Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/backend-ai-session-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2928,6 +2928,7 @@ ${rowData.item[this.sessionNameField]}</pre
class="fg blue controls-running"
id="${rowData.index + '-assignment'}"
icon="assignment"
?disabled="${rowData.item.status === 'CANCELLED'}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minor thing, but I think we shall use triple equal (===) instead of ==. Please refer here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I just changed the operator to triple equal sign.

@click="${(e) => this._showLogs(e)}"
></mwc-icon-button>
<vaadin-tooltip
Expand Down