Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Improve edu-applauncher scalability for adding session templates #2147

Merged
merged 5 commits into from
Jan 19, 2024
Merged

feature: Improve edu-applauncher scalability for adding session templates #2147

merged 5 commits into from
Jan 19, 2024

Conversation

fregataa
Copy link
Contributor

@fregataa fregataa commented Jan 15, 2024 •
edited

resolves https://github.com/lablup/giftbox/issues/614
Follow-up #1993

  • Get sessionTemplate query string and launch a session with a session template with the given name
  • Close edu-applauncher's indicator when any error raises
  • remove sleep before launching rstudio image because the issue resolved

How to test

Follow this link

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@fregataa fregataa self-assigned this Jan 15, 2024
@github-actions github-actions bot added the size:L 100~500 LoC label Jan 15, 2024
@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2147.d3g9cs6u59b8lw.amplifyapp.com

@fregataa fregataa requested a review from adrysn January 15, 2024 08:24
@fregataa fregataa added this to the 23.09 milestone Jan 15, 2024
agatha197
agatha197 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit 0846f4a into main Jan 19, 2024
6 checks passed
@yomybaby yomybaby deleted the fix/eduapp-use-session-template branch January 19, 2024 05:48
@agatha197 agatha197 mentioned this pull request Jan 25, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

@adrysn adrysn Awaiting requested review from adrysn

Assignees

@fregataa fregataa

Labels
size:L 100~500 LoC
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fregataa @agatha197 @yomybaby