Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mapping servicePorts instead string array when get services. #2177

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: mapping servicePorts instead string array when get services. #2177

merged 1 commit into from
Jan 25, 2024

Conversation

agatha197
Copy link
Contributor

follows #2147
Mapping servicePorts instead string array when get services.

Before

const servicePorts = JSON.parse(_sess.service_ports || '{}');
const services = Object.keys(servicePorts).map((s) => s.name) || [];

After

const services = Object.keys(servicePorts).map((s) => servicePorts[s].name) || [];

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minimum required manager version: 23.09
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added type:fix Fix features that are not working effort:easy Need to understand only a specific region of codes (good first issue, easy). urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. platform:general impact:invisible This change is invisible to users (internal changes). field:UI / UX labels Jan 25, 2024
@agatha197 agatha197 added this to the 24.03 milestone Jan 25, 2024
@agatha197 agatha197 self-assigned this Jan 25, 2024
@github-actions github-actions bot added size:XS ~10 LoC and removed field:UI / UX labels Jan 25, 2024
@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2177.d3g9cs6u59b8lw.amplifyapp.com

@agatha197 agatha197 merged commit a422829 into main Jan 25, 2024
13 checks passed
@agatha197 agatha197 deleted the fix/service-port-mapping-error branch January 25, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregataa fregataa fregataa approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

Assignees

@agatha197 agatha197

Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). impact:invisible This change is invisible to users (internal changes). platform:general size:XS ~10 LoC type:fix Fix features that are not working urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agatha197 @fregataa