Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add password change request alert to summary page #2238

Merged
merged 2 commits into from
Mar 4, 2024
Merged

feat: add password change request alert to summary page #2238

merged 2 commits into from
Mar 4, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Mar 4, 2024 •
edited

resolves #2229
image

How to test

  1. Log in with admin account.
  2. Click Users tab.
  3. Click the setting icon of the control column.
  4. Enable Require password change?.
image
  1. Log in with the account you just set up.

Checklist for reviewer

  • Is an alert displayed if Require password change? is true?

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version: 23.09
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added type:fix Fix features that are not working effort:easy Need to understand only a specific region of codes (good first issue, easy). area:ux UI / UX issue. urgency:4 As soon as feasible, implementation is essential. platform:general impact:visible This change is visible to users. field:UI / UX labels Mar 4, 2024
@agatha197 agatha197 added this to the 23.09 milestone Mar 4, 2024
@agatha197 agatha197 requested a review from yomybaby March 4, 2024 06:19
@agatha197 agatha197 self-assigned this Mar 4, 2024
@github-actions github-actions bot added size:M 30~100 LoC and removed field:UI / UX labels Mar 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
2.91% (-0% 🔻)
 102/3503
🔴 Branches
3.09% (-0% 🔻)
 69/2231
🔴 Functions
1.44% (-0% 🔻)
 17/1179
🔴 Lines
2.97% (-0% 🔻)
 102/3439
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🔴
... / PasswordChangeRequestAlert.tsx
 0% 0% 0% 0%

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from a77c9ea

@agatha197 agatha197 mentioned this pull request Mar 4, 2024
Closed
yomybaby
yomybaby approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (+ I pushed a commit to use token.)

@yomybaby yomybaby merged commit 991bf83 into main Mar 4, 2024
8 of 9 checks passed
@yomybaby yomybaby deleted the bugfix/password-change-request-is-not-displayed branch March 4, 2024 07:24
@yomybaby
Copy link
Member

yomybaby commented Mar 4, 2024

Thank you.
Next time, we can add a button to open UserProfileSettingModal directly. 😬 @agatha197

@agatha197 agatha197 mentioned this pull request Mar 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

Assignees

@agatha197 agatha197

Labels
area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). impact:visible This change is visible to users. platform:general size:M 30~100 LoC type:fix Fix features that are not working urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

bug: password-change-request is not displayed
2 participants
@agatha197 @yomybaby