Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display announcement alert to every page. #2239

Merged
merged 2 commits into from
Mar 5, 2024
Merged

feat: display announcement alert to every page. #2239

merged 2 commits into from
Mar 5, 2024

Conversation

agatha197
Copy link
Contributor

The password change request alert is displayed on all pages, according to the traditional implementation method.
follows #2238

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added effort:easy Need to understand only a specific region of codes (good first issue, easy). area:ux UI / UX issue. urgency:3 Must be finished within a certain time frame. type:refactor Refactoring current implementation. platform:general impact:visible This change is visible to users. field:UI / UX labels Mar 5, 2024
@agatha197 agatha197 added this to the 23.09 milestone Mar 5, 2024
@agatha197 agatha197 requested a review from yomybaby March 5, 2024 01:51
@agatha197 agatha197 self-assigned this Mar 5, 2024
@github-actions github-actions bot added size:M 30~100 LoC and removed field:UI / UX labels Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements 2.91% 102/3503
🔴 Branches 3.09% 69/2231
🔴 Functions 1.44% 17/1179
🔴 Lines 2.97% 102/3439

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from d152b11

yomybaby
yomybaby approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to add Suspense to prevent flickering of PasswordChangeRequestAlert.

LGTM.

@yomybaby yomybaby merged commit 468ff45 into main Mar 5, 2024
8 of 9 checks passed
@yomybaby yomybaby deleted the refactor/user-password-request-alert branch March 5, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

Assignees

@agatha197 agatha197

Labels
area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). impact:visible This change is visible to users. platform:general size:M 30~100 LoC type:refactor Refactoring current implementation. urgency:3 Must be finished within a certain time frame.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agatha197 @yomybaby