-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: match field version compatibility for vfolder v3 #2292
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 3.11% (-0% 🔻) |
117/3764 |
🔴 | Branches | 3.51% (-0.02% 🔻) |
87/2481 |
🔴 | Functions | 1.53% | 19/1244 |
🔴 | Lines | 3.06% (-0% 🔻) |
113/3691 |
Test suite run success
32 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from 7d5c0e0
{t('data.Limit')}: | ||
</Typography.Text> | ||
{maxVfolderCount === 0 ? '-' : maxVfolderCount} | ||
{maxVfolderCount && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if maxVfolderCount === 0
, react display 0
instead of nothing. Does maxVfolderCount === 0
means? unlimited
or 0
or -
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the codes. If maxVfolderCount
is 0, display 0. And the numberOfFolderPercent
is 100.
@yomybaby you can test by editing the max_vfolder_count
in Users - Resource Policy tab - Edit Max. # of folders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check this thread. Currently, the manager handles 0 as unlimited. It should be changed in the near future. But for now, let's display it as unlimited. @agatha197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check this out.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The count of created folders has to include virtual folders in the trash bin if the trash bin is supported, right? handled in #2302 |
original issue: #1742
related PR: lablup/backend.ai#1993
Description
_updateSupportList()
inbackend.ai-client-esm.ts
max_vfolder_count
according to the manager version.deleting
status todeadVFolderStatuses
andVFolderOperationStatus
for version compatibilityVersion compatibility (Updated at 230404)
Keypair Resource Policy
max_vfolder_count
max_quota_scope_size
max_vfolder_size
User/Project Resource Policy
max_vfolder_count
max_quota_scope_size
max_vfolder_size
How to setup
directoryBasedUsage = true
of theconfig.toml
for testing.Checklist
(* If you want to see the capacity, make sure the current host is one of the
quotaSupportStorageBackends
('xfs', 'weka', 'spectrumscale', 'netapp', 'vast', 'cephfs','ddn') anddirectoryBasedUsage
is true.)- I used
deprecated-max-quota-scope-in-keypair-resource-policy
when checking thequotaSupportStorageBackends
. referhttps://github.com/lablup/backend.ai/blob/main/src/ai/backend/manager/api/vfolder.py#L1054
max_vfolder_count
ofresource policy
column is visiblemax_vfolder_count
ofresources
column /max # of folders
when creating or modifying policy are visible.max_vfolder_count
ofuser_resource_policy
.Except that, all data is invisible.
backend.ai-webui/react/src/components/StorageStatusPanel.tsx
Lines 188 to 199 in 8933272
Checklist: (if applicable)