Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix incorrect version notation of GQL Field #1993

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

fregataa
Copy link
Contributor

@fregataa fregataa commented Apr 3, 2024

blocked by #2000

Change

  • Correct Added/Deprecated version of Resource policy GQL schema fields
  • Unify description/deprecation message to Added in {VERSION} and Deprecated since {VERSION} for consistency.
  • Unify version notation to end with .(dot). e.g. "23.09.10" -> "23.09.10."
  • Fix fields labeled as added in version "24.03.1" that were actually added in version "24.03.0"

Why are the versions so different?

KeyPairResourcePolicy

UserResourcePolicy, ProjectResourcePolicy

{Create/Modify}UserResourcePolicyInput, ProjectResourcePolicyInput

Warning

in 23.09, max_vfolder_count field of {User/Project}ResourcePolicy was removed in "23.09.3." by mistake and restored in "23.09.6.". So, the version the field was added in is "23.09.6."

  • The commit that removed max_vfolder_count from {User/Project}ResourcePolicy: f4d6b51
  • The commit that restored the field: 3d9a886

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@fregataa fregataa added this to the 23.09 milestone Apr 3, 2024
@fregataa fregataa self-assigned this Apr 3, 2024
@github-actions github-actions bot added comp:manager Related to Manager component size:M 30~100 LoC labels Apr 3, 2024
@kyujin-cho kyujin-cho changed the title chore: Correct a version notation of Resource policy GQL schema chore: fix incorrect version notation of GQL Field Apr 4, 2024
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Apr 4, 2024
@fregataa fregataa added the urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! label Apr 4, 2024
@fregataa fregataa marked this pull request as draft April 5, 2024 08:21
@fregataa fregataa removed the urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! label Apr 18, 2024
@github-actions github-actions bot added the area:docs Documentations label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants