New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix incorrect version notation of GQL Field #1993
Draft
fregataa
wants to merge
27
commits into
main
Choose a base branch
from
chore/clear-resource-policy-field-version
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+105
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
Related to Manager component
size:M
30~100 LoC
labels
Apr 3, 2024
…d-version' into chore/clear-resource-policy-field-version
kyujin-cho
changed the title
chore: Correct a version notation of Resource policy GQL schema
chore: fix incorrect version notation of GQL Field
Apr 4, 2024
…d-version' into chore/clear-resource-policy-field-version
…d-version' into chore/clear-resource-policy-field-version
…d-version' into chore/clear-resource-policy-field-version
15 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by #2000
Change
Added in {VERSION}
andDeprecated since {VERSION}
for consistency..(dot)
. e.g. "23.09.10" -> "23.09.10."Why are the versions so different?
KeyPairResourcePolicy
max_quota_scope_size
field was added by mistake in version "23.09.6", when fix: restore removed graphene fields and set them deprecated #1677 was backported (a4bad32)UserResourcePolicy, ProjectResourcePolicy
max_vfolder_size
was actually deprecated since "23.09.2", when fix: provide deprecation msg tomax_vfolder_size
graphene field #1644 was backported (2a1cc67){Create/Modify}UserResourcePolicyInput, ProjectResourcePolicyInput
max_vfolder_size
field that was removed when fix: provide deprecation msg tomax_vfolder_size
graphene field #1644 was backported to "23.09.2" (2a1cc67)Warning
in 23.09,
max_vfolder_count
field of {User/Project}ResourcePolicy was removed in "23.09.3." by mistake and restored in "23.09.6.". So, the version the field was added in is "23.09.6."max_vfolder_count
from {User/Project}ResourcePolicy: f4d6b51Checklist: (if applicable)
docs
directory