-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Project resource policy page #2423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 2.86% (-0.05% 🔻) |
140/4889 |
🔴 | Branches | 3.35% (-0.05% 🔻) |
110/3285 |
🔴 | Functions | 1.56% (-0.03% 🔻) |
25/1606 |
🔴 | Lines | 2.75% (-0.04% 🔻) |
132/4799 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | ... / ProjectResourcePolicyList.tsx |
0% | 0% (-100% 🔻) |
0% | 0% |
Test suite run success
48 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from a741b80
699bec6
to
3553d79
Compare
17 tasks
3553d79
to
63e6cdf
Compare
63e6cdf
to
74fb2bc
Compare
14 tasks
0f9729c
to
8180a53
Compare
b6598bf
to
d005213
Compare
8180a53
to
5097d55
Compare
d005213
to
e33ef2c
Compare
5097d55
to
f93c982
Compare
100e1b6
to
73b9b2a
Compare
d232e78
to
15659aa
Compare
73b9b2a
to
bc753ef
Compare
yomybaby
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
15659aa
to
ce2f605
Compare
bc753ef
to
130018b
Compare
130018b
to
a741b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows #2357
Add Project Resource Policy Page
TL;DR
This pull request introduces changes related to FormItemWithUnlimited and ProjectResourcePolicyList components.
What changed?
The changes include:
FormItemWithUnlimited
componentProjectResourcePolicyList
component with enhanced functionality and UI improvementsChecklist
max_vfolder_count
is supported from version 24.03.1, but this is incorrectly documented, and it follows chore: fix incorrect version notation of GQL Field backend.ai#1993.Max Folder Count
is 0.Max Folder Size
is -1.Screenshots
Checklist: (if applicable)