Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Project resource policy page #2423

Merged
merged 2 commits into from
May 28, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented May 23, 2024

follows #2357
Add Project Resource Policy Page

TL;DR

This pull request introduces changes related to FormItemWithUnlimited and ProjectResourcePolicyList components.

What changed?

The changes include:

  • Addition of FormItemWithUnlimitedProps in FormItemWithUnlimited component
  • Updates to ProjectResourcePolicyList component with enhanced functionality and UI improvements

Checklist

  • List Page: name, max folder count, max quota scope size, id, created at
  • Create/Modal: Create or modify project resource policy.
    • Version compatibility is the same as the list.
    • Unlimited value of Max Folder Count is 0.
    • Unlimited value of Max Folder Size is -1.

Screenshots

24.09.0dev1 (main)
List

image.png

Create Modal

image.png

Modify Modal

image.png

Table Setting

image.png


Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added area:lib Library and SDK related issue. area:ux UI / UX issue. area:i18n Localization labels May 23, 2024
Copy link
Contributor Author

agatha197 commented May 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the size:XL 500~ LoC label May 23, 2024
Copy link

github-actions bot commented May 23, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
2.86% (-0.05% 🔻)
140/4889
🔴 Branches
3.35% (-0.05% 🔻)
110/3285
🔴 Functions
1.56% (-0.03% 🔻)
25/1606
🔴 Lines
2.75% (-0.04% 🔻)
132/4799
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / ProjectResourcePolicyList.tsx
0%
0% (-100% 🔻)
0% 0%

Test suite run success

48 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from a741b80

@agatha197 agatha197 force-pushed the 05-23-feature_project-resource-policy-page branch 3 times, most recently from 699bec6 to 3553d79 Compare May 23, 2024 09:08
@agatha197 agatha197 marked this pull request as ready for review May 23, 2024 09:21
@yomybaby yomybaby force-pushed the 05-23-feature_project-resource-policy-page branch from 3553d79 to 63e6cdf Compare May 24, 2024 08:51
@agatha197 agatha197 force-pushed the 05-23-feature_project-resource-policy-page branch from 63e6cdf to 74fb2bc Compare May 24, 2024 15:41
@agatha197 agatha197 changed the base branch from main to 05-22-feature_user-resource-policy-page May 24, 2024 15:41
@agatha197 agatha197 mentioned this pull request May 24, 2024
14 tasks
@agatha197 agatha197 force-pushed the 05-22-feature_user-resource-policy-page branch from 0f9729c to 8180a53 Compare May 24, 2024 15:44
@agatha197 agatha197 force-pushed the 05-23-feature_project-resource-policy-page branch 2 times, most recently from b6598bf to d005213 Compare May 24, 2024 16:05
@agatha197 agatha197 force-pushed the 05-22-feature_user-resource-policy-page branch from 8180a53 to 5097d55 Compare May 24, 2024 16:07
@agatha197 agatha197 force-pushed the 05-23-feature_project-resource-policy-page branch from d005213 to e33ef2c Compare May 24, 2024 16:07
@yomybaby yomybaby changed the title feature/project-resource-policy-page feat: Project resource policy page May 27, 2024
@yomybaby yomybaby force-pushed the 05-22-feature_user-resource-policy-page branch from 5097d55 to f93c982 Compare May 27, 2024 09:52
@yomybaby yomybaby force-pushed the 05-23-feature_project-resource-policy-page branch 2 times, most recently from 100e1b6 to 73b9b2a Compare May 27, 2024 10:19
@yomybaby yomybaby force-pushed the 05-22-feature_user-resource-policy-page branch from d232e78 to 15659aa Compare May 27, 2024 10:33
@yomybaby yomybaby force-pushed the 05-23-feature_project-resource-policy-page branch from 73b9b2a to bc753ef Compare May 27, 2024 10:33
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the 05-22-feature_user-resource-policy-page branch from 15659aa to ce2f605 Compare May 27, 2024 10:42
@yomybaby yomybaby force-pushed the 05-23-feature_project-resource-policy-page branch from bc753ef to 130018b Compare May 27, 2024 10:42
Copy link
Member

yomybaby commented May 28, 2024

Merge activity

  • May 27, 9:23 PM EDT: @yomybaby started a stack merge that includes this pull request via Graphite.
  • May 27, 9:24 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 27, 9:25 PM EDT: @yomybaby merged this pull request with Graphite.

Base automatically changed from 05-22-feature_user-resource-policy-page to main May 28, 2024 01:24
@yomybaby yomybaby force-pushed the 05-23-feature_project-resource-policy-page branch from 130018b to a741b80 Compare May 28, 2024 01:24
@yomybaby yomybaby merged commit 6f4a581 into main May 28, 2024
5 checks passed
@yomybaby yomybaby deleted the 05-23-feature_project-resource-policy-page branch May 28, 2024 01:25
@agatha197 agatha197 added this to the 24.03 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants