Skip to content

Commit

Permalink
chore(tests): remove unused env-tester files (#1956)
Browse files Browse the repository at this point in the history
Backported-from: main (24.09)
Backported-to: 23.09
Co-authored-by: Joongi Kim <joongi@lablup.com>
  • Loading branch information
mirageoasis and achimnol committed Apr 8, 2024
1 parent 71140d1 commit 1727af3
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 13 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ jobs:
shell: 'script -q -e -c "bash {0}"'
run: |
./scripts/install-dev.sh
source env-tester-admin.sh
./backend.ai test run-cli admin
source env-tester-user.sh
./backend.ai test run-cli user
- name: Upload pants log
uses: actions/upload-artifact@v4
Expand Down
1 change: 1 addition & 0 deletions changes/1956.deprecation.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove no longer used `env-tester-{admin,user,user2}.sh` scripts and all references
11 changes: 0 additions & 11 deletions scripts/install-dev.sh
Original file line number Diff line number Diff line change
Expand Up @@ -941,11 +941,6 @@ configure_backendai() {
show_note "The currently embedded webui version: $webui_version"
fi

# configure tester
echo "export BACKENDAI_TEST_CLIENT_ENV=${PWD}/env-local-admin-api.sh" > ./env-tester-admin.sh
echo "export BACKENDAI_TEST_CLIENT_ENV=${PWD}/env-local-user-api.sh" > ./env-tester-user.sh
echo "export BACKENDAI_TEST_CLIENT_ENV=${PWD}/env-local-user2-api.sh" > ./env-tester-user2.sh

if [ "${CODESPACES}" = "true" ]; then
$docker_sudo docker stop $($docker_sudo docker ps -q)
$docker_sudo docker compose -f "docker-compose.halfstack.current.yml" down
Expand Down Expand Up @@ -1085,12 +1080,6 @@ configure_backendai() {
echo "echo 'Password: $(cat fixtures/manager/example-keypairs.json | jq -r '.users[] | select(.username=="user") | .password')'" >> "${CLIENT_USER_CONF_FOR_SESSION}"
chmod +x "${CLIENT_USER_CONF_FOR_SESSION}"

# TODO: Update tester env script
## sed_inplace "s@export BACKENDAI_TEST_CLIENT_VENV=/home/user/.pyenv/versions/venv-dev-client@export BACKENDAI_TEST_CLIENT_VENV=${VENV_PATH}@" ./env-tester-admin.sh
## sed_inplace "s@export BACKENDAI_TEST_CLIENT_ENV=/home/user/bai-dev/client-py/my-backend-session.sh@export BACKENDAI_TEST_CLIENT_ENV=${INSTALL_PATH}/client-py/${CLIENT_ADMIN_CONF_FOR_API}@" ./env-tester-admin.sh
## sed_inplace "s@export BACKENDAI_TEST_CLIENT_VENV=/home/user/.pyenv/versions/venv-dev-client@export BACKENDAI_TEST_CLIENT_VENV=${VENV_PATH}@" ./env-tester-user.sh
## sed_inplace "s@export BACKENDAI_TEST_CLIENT_ENV=/home/user/bai-dev/client-py/my-backend-session.sh@export BACKENDAI_TEST_CLIENT_ENV=${INSTALL_PATH}/client-py/${CLIENT_USER_CONF_FOR_API}@" ./env-tester-user.sh

show_info "Dumping the installed etcd configuration to ./dev.etcd.installed.json as a backup."
./backend.ai mgr etcd get --prefix '' > ./dev.etcd.installed.json

Expand Down

0 comments on commit 1727af3

Please sign in to comment.