Skip to content

Commit

Permalink
fix: VFolder file listing not working (#2072)
Browse files Browse the repository at this point in the history
Resolves lablup/giftbox#661. This PR fixes VFolder I/O operation APIs not working when user tries to call API to a VFolder which shares name with deleted one, which is caused by `vfolder_permission_required()` decorator selecting already removed VFolder instead of live one. Adding these kind of extra filters will make the codebase coarsened, so our ultimate goal is to retire every VFolder APIs utilizing VFolder name as its key to resolve target VFolder.

**Checklist:** (if applicable)

- [x] Milestone metadata specifying the target backport version
- [x] Mention to the original issue
<!-- readthedocs-preview sorna start -->
----
📚 Documentation preview 📚: https://sorna--2072.org.readthedocs.build/en/2072/

<!-- readthedocs-preview sorna end -->

<!-- readthedocs-preview sorna-ko start -->
----
📚 Documentation preview 📚: https://sorna-ko--2072.org.readthedocs.build/ko/2072/

<!-- readthedocs-preview sorna-ko end -->

<!-- readthedocs-preview sorna start -->
----
📚 Documentation preview 📚: https://sorna--2072.org.readthedocs.build/en/2072/

<!-- readthedocs-preview sorna end -->

<!-- readthedocs-preview sorna-ko start -->
----
📚 Documentation preview 📚: https://sorna-ko--2072.org.readthedocs.build/ko/2072/

<!-- readthedocs-preview sorna-ko end -->

<!-- readthedocs-preview sorna start -->
----
📚 Documentation preview 📚: https://sorna--2072.org.readthedocs.build/en/2072/

<!-- readthedocs-preview sorna end -->

<!-- readthedocs-preview sorna-ko start -->
----
📚 Documentation preview 📚: https://sorna-ko--2072.org.readthedocs.build/ko/2072/

<!-- readthedocs-preview sorna-ko end -->

<!-- readthedocs-preview sorna start -->
----
📚 Documentation preview 📚: https://sorna--2072.org.readthedocs.build/en/2072/

<!-- readthedocs-preview sorna end -->
  • Loading branch information
kyujin-cho committed Apr 28, 2024
1 parent d0e0b89 commit eb6bcad
Show file tree
Hide file tree
Showing 3 changed files with 265 additions and 211 deletions.
1 change: 1 addition & 0 deletions changes/2072.fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix VFolder file operation not working when user has been granted access to shared but deleted VFolder which has same name with the normal one

0 comments on commit eb6bcad

Please sign in to comment.