Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index agent's kernel registry by backend-dependent key #1196

Open
sanxiyn opened this issue Mar 26, 2023 · 0 comments
Open

Index agent's kernel registry by backend-dependent key #1196

sanxiyn opened this issue Mar 26, 2023 · 0 comments

Comments

@sanxiyn
Copy link
Contributor

sanxiyn commented Mar 26, 2023

Currently, agent's kernel registry is indexed by kernel_id, which is the backend-independent key. Backends are not aware of it, for example, Docker backend only knows about container_id of its containers.

Sometimes we need to look up kernel by backend-dependent key. Currently, we do this by creating a temporary index by iterating over entire kernel registry. kernel_id_map: Dict[ContainerId, KernelId] in stats.py is an example. Instead, we should make this index permanent and update it whenever kernel registry is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant