Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it available to create a project folder regardless of max_vfolder_count. #1391

Closed
agatha197 opened this issue Jul 13, 2023 · 2 comments · Fixed by #1397
Closed

Make it available to create a project folder regardless of max_vfolder_count. #1391

agatha197 opened this issue Jul 13, 2023 · 2 comments · Fixed by #1397
Assignees
@pderer
Labels
comp:manager Related to Manager component effort:normal Need to understand a few modules / some extent of contextual or historical information. platform:general General platform issues. Most issues are general. type:bug Reports about that are not working urgency:4 As soon as feasible, implementation is essential.
Milestone
22.09

Comments

@agatha197
Copy link
Contributor

What Operating System(s) are you seeing this problem on?

macOS (Apple Silicon)

Backend.AI version

23.03

Describe the bug

If a number of created user vfolder is the same as max_vfolder_count, the admin cannot create a new project folder.
The number of project folder limit should be related to the ProjectResourcePolicy not KeypairResourcePolicy.

So let's make it available to create a project folder regardless of max_vfolder_count.
If possible, let's add max_vfolder_count to the ProjectResourcePolicy and limit the number of creating project folders using that.

To Reproduce

Create as many user folders as max_vfolder_count and create a project folder. A new project folder cannot be created, even though it must be created regardless of max_vfolder_count.

Expected Behavior

Project folder should be created.

Anything else?

No response
@agatha197 agatha197 added type:bug Reports about that are not working comp:manager Related to Manager component effort:normal Need to understand a few modules / some extent of contextual or historical information. platform:general General platform issues. Most issues are general. urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. labels Jul 13, 2023
@agatha197 agatha197 added this to the 22.09 milestone Jul 13, 2023
@achimnol achimnol mentioned this issue Jul 13, 2023
Closed
@agatha197 agatha197 added urgency:4 As soon as feasible, implementation is essential. and removed urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. labels Jul 13, 2023
@agatha197
Copy link
Contributor Author

Dongjin Park will handle this.

@achimnol achimnol mentioned this issue Jul 13, 2023
Closed
6 tasks
@achimnol
Copy link
Member

This was supposed to be handled as part of #384.
This issue should be resolved first and then we need to work on #1392.

@achimnol achimnol assigned achimnol and pderer and unassigned achimnol Jul 13, 2023
@pderer pderer mentioned this issue Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pderer pderer

Labels
comp:manager Related to Manager component effort:normal Need to understand a few modules / some extent of contextual or historical information. platform:general General platform issues. Most issues are general. type:bug Reports about that are not working urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Milestone
22.09
Development

Successfully merging a pull request may close this issue.

fix: avoid checking max_vfolder_count lablup/backend.ai
3 participants
@achimnol @agatha197 @pderer