Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid checking max_vfolder_count #1397

Merged
merged 7 commits into from Aug 29, 2023
Merged

fix: avoid checking max_vfolder_count #1397

merged 7 commits into from Aug 29, 2023

Conversation

pderer
Copy link
Contributor

@pderer pderer commented Jul 14, 2023

This PR resolves #1391.

@pderer pderer added type:bug Reports about that are not working comp:manager Related to Manager component effort:normal Need to understand a few modules / some extent of contextual or historical information. platform:general General platform issues. Most issues are general. size:XS ~10 LoC urgency:4 As soon as feasible, implementation is essential. labels Jul 14, 2023
@pderer pderer added this to the 22.09 milestone Jul 14, 2023
@pderer pderer self-assigned this Jul 14, 2023
@github-actions github-actions bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Jul 14, 2023
agatha197
agatha197 requested changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is keypair max_vfolder_count affect project folder creation.

fix: check "max_vfolder_count" in creating vfolder
67619bb 
- only if ownership type is "user".
  if owernship type is "group", don't check it.
@github-actions github-actions bot added size:XS ~10 LoC and removed size:S 10~30 LoC labels Jul 14, 2023
@pderer
Copy link
Contributor Author

pderer commented Jul 14, 2023

The problem is keypair max_vfolder_count affect project folder creation.

I fix it in create vfolder function, but there is a bug in clone function too.
Decision is that clone function return user ownership type, and admin can clone project ownership type regardless of max_vfolder_count.
I may fix it in this PR.
But if I modify the code too much, I will create a new issue.

@kyujin-cho kyujin-cho added the urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! label Jul 17, 2023
@pderer pderer mentioned this pull request Jul 17, 2023
Merged
@pderer
Copy link
Contributor Author

pderer commented Jul 17, 2023

I made a new PR because the added issue is focused on the clone function. (#1400)

@pderer pderer requested a review from agatha197 July 19, 2023 02:39
@achimnol achimnol reopened this Aug 29, 2023
@achimnol achimnol disabled auto-merge August 29, 2023 02:56
@achimnol
Copy link
Member

It seems that I have accidentally closed this PR in favor of #1400 as it described that #1400 includes #1397, but the actual code diff does not.

@achimnol achimnol added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 43148f2 Aug 29, 2023
21 checks passed
@achimnol achimnol deleted the fix/avoid-using-keypair-resource-policy-max-vfolder-count branch August 29, 2023 03:16
achimnol pushed a commit that referenced this pull request Aug 29, 2023
@pderer @achimnol
fix: avoid checking max_vfolder_count (#1397)
5d12210 
Backported-from: main
Backported-to: 23.03
achimnol added a commit that referenced this pull request Aug 29, 2023
@pderer @achimnol
fix: avoid checking max_vfolder_count (#1397)
2d082f1 
Co-authored-by: Joongi Kim <joongi@lablup.com>
Backported-from: main
Backported-to: 22.09
@fregataa fregataa mentioned this pull request Oct 23, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol Awaiting requested review from achimnol

@kyujin-cho kyujin-cho Awaiting requested review from kyujin-cho

@agatha197 agatha197 Awaiting requested review from agatha197

Assignees

@pderer pderer

Labels
comp:manager Related to Manager component effort:normal Need to understand a few modules / some extent of contextual or historical information. platform:general General platform issues. Most issues are general. size:XS ~10 LoC type:bug Reports about that are not working urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Milestone
22.09
Development

Successfully merging this pull request may close these issues.

Make it available to create a project folder regardless of max_vfolder_count.
4 participants
@pderer @achimnol @agatha197 @kyujin-cho