Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ModifyGroup.{user_uuids,user_update_mode} and add AddUsersToGroup, RemoveUsersFromGroup mutations #1697

Open
1 of 3 tasks
achimnol opened this issue Nov 7, 2023 · 0 comments · May be fixed by #1705
Open
1 of 3 tasks

Deprecate ModifyGroup.{user_uuids,user_update_mode} and add AddUsersToGroup, RemoveUsersFromGroup mutations #1697

achimnol opened this issue Nov 7, 2023 · 0 comments · May be fixed by #1705
Assignees
@fregataa
Labels
comp:manager Related to Manager component type:refactor Refactor codes or add tests.
Milestone
24.09

Comments

@achimnol
Copy link
Member

achimnol commented Nov 7, 2023 •
edited by fregataa
Loading

Another follow-up to #1688.
Let's make the GraphQL API more self-explanatory.
Let's not be afraid of adding mutations like this.

  • Make the user_update_mode working with graphql.Undefined
  • Add AddUsersToGroup, RemoveUsersFromGroup mutations
  • For backward compatibility, we need to keep the legacy fields for a while but let's add deprecation messages to indicate that they are replaced with new separate mutations.
@achimnol achimnol added urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! comp:manager Related to Manager component type:refactor Refactor codes or add tests. labels Nov 7, 2023
@achimnol achimnol added this to the 23.09 milestone Nov 7, 2023
This was referenced Nov 7, 2023
Merged
Draft
@fregataa fregataa removed the urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! label Apr 25, 2024
@fregataa fregataa modified the milestones: 23.09, 24.09 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fregataa fregataa

Labels
comp:manager Related to Manager component type:refactor Refactor codes or add tests.
Projects
None yet
Milestone
24.09
Development

Successfully merging a pull request may close this issue.

refactor: Add users_to_add and users_to_remove fields to replace user update mode lablup/backend.ai
2 participants
@achimnol @fregataa