Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use the original image entrypoint when creating session containers #2219

Open
achimnol opened this issue May 29, 2024 · 0 comments
Labels
comp:agent Related to Agent component comp:manager Related to Manager component type:feature Add new features
Milestone

Comments

@achimnol
Copy link
Member

Sometimes users may want to run the original image entrypoint in addition to our entrypoint.sh.
It is "easy" to just execute yet another command from entrypoint.sh by passing the original entrypoint to the container via configuration files or environment variables, but there are several technical considerations, though:

  • The image's original entrypoint command/script may assume the "root" privilege, while our entrypoint.sh switches to the plain work user.
  • We should keep our kernel runner to become ready even if the original entrypoint script takes a long time or fails, to make the container "usable" at least.
    • The execution of the original entrypoint script should be done asynchronously and we should have a way to expose its execution log.
@achimnol achimnol added type:feature Add new features comp:manager Related to Manager component comp:agent Related to Agent component labels May 29, 2024
@achimnol achimnol added this to the 24.09 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component comp:manager Related to Manager component type:feature Add new features
Projects
None yet
Development

No branches or pull requests

1 participant