Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize docker cgroup driver support #363

Closed
Tracked by #134
achimnol opened this issue Feb 9, 2022 · 3 comments · Fixed by #1000
Closed
Tracked by #134

Generalize docker cgroup driver support #363

achimnol opened this issue Feb 9, 2022 · 3 comments · Fixed by #1000
Assignees
Labels
comp:agent Related to Agent component type:feature Add new features
Milestone

Comments

@achimnol
Copy link
Member

achimnol commented Feb 9, 2022

Currently the agent adds our own cgroup control routines to retrieve container statistics of containers after their termination on top of Docker's cgroupfs lifecycle.

This works well with the default cgroup driver, but there are reports that it conflicts with the "systemd" cgroup driver. The relevant configuration option name is native.cgroupdriver.

There seems no big technical difference between systemd-managed cgroups and cgroupfs-based cgroups, but they have different directory namings under the sysfs. It is also notable that Kubernetes recommends to use the "systemd" cgroup driver and keep the configurations for kubelets and Docker same.

Let's support both types of cgroup drivers to prevent unexpected conflicts on various systems, by adding auto-detection of the current cgroup driver and using different directory names that match with each driver when collecting stats.

@achimnol achimnol added type:feature Add new features comp:agent Related to Agent component labels Feb 9, 2022
@achimnol achimnol added this to the 22.03 milestone Feb 9, 2022
@adrysn
Copy link
Member

adrysn commented Feb 9, 2022

@achimnol
Copy link
Member Author

This is an extension to #134.

@achimnol achimnol mentioned this issue Nov 9, 2022
4 tasks
@achimnol
Copy link
Member Author

achimnol commented Nov 9, 2022

Related with #865

@qkoo0833 qkoo0833 self-assigned this Dec 26, 2022
qkoo0833 added a commit that referenced this issue Dec 27, 2022
1. Automatically detect docker's current cgroup driver

2. Match different path prefix with each driver

resolve #363
@achimnol achimnol modified the milestones: 22.03, 22.09 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component type:feature Add new features
Projects
None yet
4 participants