Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unreasonable ondelete restrictions of certain foreign keys #1935

Merged
merged 11 commits into from Mar 4, 2024
Merged

fix: unreasonable ondelete restrictions of certain foreign keys #1935

merged 11 commits into from Mar 4, 2024

Conversation

fregataa
Copy link
Contributor

@fregataa fregataa commented Feb 27, 2024 •
edited

  • Change endpoints.model to nullable and set ondelete="NULL"
  • Set endpoint_tokens.endpoint ondelete="NULL"

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

@fregataa fregataa added this to the 24.03 milestone Feb 27, 2024
@fregataa fregataa self-assigned this Feb 27, 2024
@github-actions github-actions bot added comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:M 30~100 LoC labels Feb 27, 2024
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Feb 27, 2024
@fregataa fregataa marked this pull request as draft February 28, 2024 08:13
@fregataa fregataa marked this pull request as ready for review February 28, 2024 19:29
@kyujin-cho kyujin-cho changed the title fix: Change endpoints.model and endpoint_tokens.endpoint to nullable fix: unreasonable ondelete restrictions for foreign keys referencing vfolders / endpoints Mar 4, 2024
@kyujin-cho kyujin-cho changed the title fix: unreasonable ondelete restrictions for foreign keys referencing vfolders / endpoints fix: unreasonable ondelete restrictions for foreign keys Mar 4, 2024
@kyujin-cho kyujin-cho changed the title fix: unreasonable ondelete restrictions for foreign keys fix: unreasonable ondelete restrictions for foreign keys Mar 4, 2024
@kyujin-cho kyujin-cho changed the title fix: unreasonable ondelete restrictions for foreign keys fix: unreasonable ondelete restrictions of certain foreign keys Mar 4, 2024
@kyujin-cho kyujin-cho added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 82f5a64 Mar 4, 2024
30 checks passed
@kyujin-cho kyujin-cho deleted the fix/endpoint-nullable branch March 4, 2024 15:40
kyujin-cho added a commit that referenced this pull request Mar 4, 2024
@fregataa @kyujin-cho
fix: unreasonable ondelete restrictions of certain foreign keys (#1935
90fef27 
)

Backported-from: main
Backported-to: 23.09
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com>
@fregataa fregataa mentioned this pull request Mar 24, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyujin-cho kyujin-cho kyujin-cho requested changes

@adrysn adrysn Awaiting requested review from adrysn

Assignees

@fregataa fregataa

Labels
comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fregataa @kyujin-cho